Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: also allow mock_data and mock_resource blocks to generate data during planning #36317

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

liamcervante
Copy link
Member

This is a quick follow up to #36227. We're extending the same functionality to the mock_resource and mock_data blocks that wasn't included in the last PR.

There's a small refactor to compute the override_during value at the provider level instead of at the mock_data level. This means we can also use the value defined on the provider if we're loading mock data from external sources. In addition, the refactor lets us get rid of the boolean pointer fields that I found confusing. Now, the functions all require a default value that can be provided by the source value at the provider level.

@liamcervante liamcervante merged commit 408f323 into main Jan 15, 2025
7 checks passed
@liamcervante liamcervante deleted the liamcervante/mock-data-override branch January 15, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants