FIX URI path handling to remove double slashes #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix request URI to remove double slashes. Vault server returns 301 redirect for double slash URIs, requiring resending. Since Vault server v1.17.3, the redirect URL has changed. For example, take key: `/cubbyhole/my-secret`: - Before vault v1.17.2, vault-ruby sends `/v1//cubbyhole/my%2Dsecret`, and the Vault server returns `/v1/cubbyhole/my-secret`. - After vault v1.17.3, vault-ruby sends `/v1//cubbyhole/my%2Dsecret`, and the Vault server returns `/v1/cubbyhole/my%252Dsecret`. Thus, the behavior is not the same. Removing the double slashes prevents the redirect mechanism from being triggered.
|
@TaopaiC we have a similar problem with v1.17.3. Our Problem seems to be that v1.17.3 'double-encodes' the URI. |
@ochnerd We found that the issue occurred after upgrading to Go 1.22.5 in commit hashicorp/vault@68e9f39 . Two of possible solutions are:
This PR attempts to implement solution 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix request URI to remove double slashes.
Vault server returns 301 redirect for double slash URIs, requiring resending. Since Vault server v1.17.3, the redirect URL has changed.
For example, take key:
/cubbyhole/my-secret:/v1//cubbyhole/my%2Dsecret, and the Vault server returns/v1/cubbyhole/my-secret./v1//cubbyhole/my%2Dsecret, and the Vault server returns/v1/cubbyhole/my%252Dsecret.Thus, the behavior is not the same. Removing the double slashes prevents the redirect mechanism from being triggered.