[VAULT-19467] UI Breadcrumb Title Case #29206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
beagins
added
ui
and removed
hashicorp-contributed-pr
|
|
beagins
added
the
hashicorp-contributed-pr
|
CI Results: |
beagins
force-pushed
the
ui/VAULT-19467/breadcrumb-title-case
branch
5 times, most recently
from
491d5fb to
8a15ebb
Compare
beagins
force-pushed
the
ui/VAULT-19467/breadcrumb-title-case
branch
from
8a15ebb to
d3d1e72
Compare
|
Build Results: |
Monkeychip
reviewed
Dec 18, 2024
| assert | ||
| .dom('[data-test-breadcrumbs] li:nth-child(3)') | ||
| .containsText('test-library', 'Library breadcrumb renders'); | ||
| assert | ||
| .dom('[data-test-breadcrumbs] li:nth-child(4)') | ||
| .containsText('check-out', 'Check-out breadcrumb renders'); | ||
| .containsText('Check-Out', 'Check-out breadcrumb renders'); |
There was a problem hiding this comment.
nice on this one, I had to google it because i would have gotten it incorrect.
There was a problem hiding this comment.
I 100% had to google it because I wasn't sure either lol 😆
|
Ran |
hellobontempo
approved these changes
Dec 20, 2024
beagins
added
backport/ent/1.16.x+ent
6 tasks
beagins
added a commit
that referenced
this pull request
Jan 24, 2025
* [VAULT-19467] Vault UI Breadcrumb Title Case * should use Title Case * update changelog * rename changelog * update tests * more test updates * update tests --------- Co-authored-by: Tony Wittinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
All static breadcrumbs should be title case formatted.
After:
Before:
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.