Add serial_number_source option to PKI role
#29369
Open
+132
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good 👍
Could you add an improvement changelog entry for this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25708
Description
This PR adds the
serial_number_sourceoption to PKI roles. This field can be one of two values:json-csr: the value from the JSONserial_numberfield is used, falling back to the value in the CSR if empty. This is the current behaviour.json: the value from theserial_numberJSON field is used, ignoring the value in the CSR`This allows the user to ignore the serial number value in the CSR like the other fields which can have their values taken from the CSR (CN, SANs, etc).