Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-kms-wrapping wrapper dependencies, adding ParsePaths support for sensitive values. #29402

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

sgmiller
Copy link
Collaborator

@sgmiller sgmiller commented Jan 23, 2025

For seal and managed key configuration (enterprise only for the latter), some config values are sensitive and can be stored in config files or via the API, but need to grab their actual values from an environment variable or file of the operator's choosing. Many of the values were configurable via env var today, but a fixed env var.

Now, for sensitive values, in addition to a static string, two special forms are supported:

env://env var name - Will read the actual value from env var name
file://file path - Will read the actual value from a file at the given path.

@sgmiller sgmiller requested a review from a team as a code owner January 23, 2025 22:15
@sgmiller sgmiller requested a review from ldilalla-HC January 23, 2025 22:15
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 23, 2025
@sgmiller sgmiller added this to the 1.19.0-rc milestone Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jan 23, 2025

Build Results:
All builds succeeded! ✅

@sgmiller sgmiller marked this pull request as draft January 23, 2025 22:19
@sgmiller
Copy link
Collaborator Author

Made draft to add docs to this PR first.

@sgmiller sgmiller marked this pull request as ready for review January 23, 2025 22:49
@sgmiller sgmiller requested review from a team as code owners January 23, 2025 22:49
stevendpclark
stevendpclark previously approved these changes Jan 24, 2025
@sgmiller sgmiller enabled auto-merge (squash) February 3, 2025 18:18
@sgmiller sgmiller merged commit 73a98dd into main Feb 3, 2025
92 of 93 checks passed
@sgmiller sgmiller deleted the sgm/update-gkw-1.19 branch February 3, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants