Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CE changes for VAULT-33018 #29470

Merged
merged 2 commits into from
Jan 31, 2025
Merged

CE changes for VAULT-33018 #29470

merged 2 commits into from
Jan 31, 2025

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Jan 31, 2025

Description

These are the CE changes and changelog for https://github.com/hashicorp/vault-enterprise/pull/7185

TODO only if you're a HashiCorp employee

  • [-] Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • [-] LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • [-] ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • [-] RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@tvoran tvoran requested a review from hashiblaum January 31, 2025 08:41
@tvoran tvoran requested a review from a team as a code owner January 31, 2025 08:41
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 31, 2025
Copy link

github-actions bot commented Jan 31, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jan 31, 2025

Build Results:
All builds succeeded! ✅

@tvoran tvoran added this to the 1.19.0-rc milestone Jan 31, 2025
Copy link
Member

@hashiblaum hashiblaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tvoran tvoran merged commit 6a87419 into main Jan 31, 2025
91 of 93 checks passed
@tvoran tvoran deleted the VAULT-33018/ce-changes branch January 31, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants