-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand on import transform docs #29478
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Results: |
Build Results: |
mercedesbh
reviewed
Feb 3, 2025
@@ -156,7 +156,9 @@ These can be combined using `and`, `or`, and `not`: | |||
|
|||
#### Transformers | |||
|
|||
Transform stanzas come in two forms: `exact` and `regexp`. | |||
Transform stanzas come in two forms: `exact` and `regexp`. For each secret found in the source, | |||
the CLI examples each transform in order. As soon as one applies to the source secret, all subsequent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is examples
the word we want here?
mercedesbh
reviewed
Feb 3, 2025
@@ -189,3 +196,50 @@ The `from` value supports parentheses to bookend capture groups and named | |||
capture groups using the syntax `(?P<name>re)`. When you use named capture | |||
groups, you can reference the named group in the `to` value. For example, | |||
`$name` instead of `$1`. | |||
|
|||
Unfortunately `$` has special meaning inside HCL files: it's used to reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Unfortunately `$` has special meaning inside HCL files: it's used to reference | |
Unfortunately, `$` has special meaning inside HCL files: it's used to reference |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
pr/no-changelog
pr/no-milestone
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.