Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand on import transform docs #29478

Closed
wants to merge 1 commit into from

Conversation

ncabatoff
Copy link
Collaborator

Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 31, 2025
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Feb 3, 2025

Build Results:
All builds succeeded! ✅

@@ -156,7 +156,9 @@ These can be combined using `and`, `or`, and `not`:

#### Transformers

Transform stanzas come in two forms: `exact` and `regexp`.
Transform stanzas come in two forms: `exact` and `regexp`. For each secret found in the source,
the CLI examples each transform in order. As soon as one applies to the source secret, all subsequent

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is examples the word we want here?

@@ -189,3 +196,50 @@ The `from` value supports parentheses to bookend capture groups and named
capture groups using the syntax `(?P<name>re)`. When you use named capture
groups, you can reference the named group in the `to` value. For example,
`$name` instead of `$1`.

Unfortunately `$` has special meaning inside HCL files: it's used to reference

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Unfortunately `$` has special meaning inside HCL files: it's used to reference
Unfortunately, `$` has special meaning inside HCL files: it's used to reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants