Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore database_ent.proto from buf linter #29492

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

thyton
Copy link
Contributor

@thyton thyton commented Feb 3, 2025

Description

What does this PR do?
This PR ignores ssdk/database/dbplugin/v5/proto/database_ent.proto in buf.yaml to fix protobuf linter. The PR ensures no diff between CE and ENT repos as the change was added in https://github.com/hashicorp/vault-enterprise/pull/7347.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@thyton thyton requested a review from a team as a code owner February 3, 2025 22:23
@thyton thyton requested review from hashneo and removed request for hashneo February 3, 2025 22:23
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 3, 2025
@thyton thyton added pr/no-changelog pr/no-milestone backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent and removed backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Feb 3, 2025
@thyton thyton requested a review from a team February 3, 2025 22:27
Copy link

github-actions bot commented Feb 3, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Feb 3, 2025

Build Results:
All builds succeeded! ✅

@thyton thyton merged commit 6f8b5da into main Feb 4, 2025
120 of 123 checks passed
@thyton thyton deleted the thyton/VAULT-33548/exclude-database-ent-proto-linter branch February 4, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants