Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEN-126: Migrate hCore from Webpack 4 to Vite #53

Merged
merged 31 commits into from
Dec 14, 2023
Merged

GEN-126: Migrate hCore from Webpack 4 to Vite #53

merged 31 commits into from
Dec 14, 2023

Commits on Dec 12, 2023

  1. Vite conversion; all but web workers are now online.

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    517f444 View commit details
    Browse the repository at this point in the history

  2. Clean out old package.json dependnecies

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    fa72ff3 View commit details
    Browse the repository at this point in the history

  3. remove core's webpack config and other unused packages

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    4c1ef8a View commit details
    Browse the repository at this point in the history

  4. Restore working engine-web 'test' and 'build-stdlib' scripts

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    66f5dcd View commit details
    Browse the repository at this point in the history

  5. repair 'yarn test'

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    90bb618 View commit details
    Browse the repository at this point in the history

  6. update browserslist target to match vite's target 

    https://vitejs.dev/guide/build#browser-compatibility
    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    151277b View commit details
    Browse the repository at this point in the history

  7. repair yarn build/start by fixing a bug in how we passed 'max_old_spa… 

    …ce_size'
    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    8f696d5 View commit details
    Browse the repository at this point in the history

  8. build improvements 

    - remove sentry.io
- .gitignore 'dist'
- include 'embed.html' in the output
    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c1186e3 View commit details
    Browse the repository at this point in the history

  9. yarn fmt

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    7f8682c View commit details
    Browse the repository at this point in the history

  10. Add vite-env.d.ts to provide vite environment types

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    8688927 View commit details
    Browse the repository at this point in the history

  11. Add type-aware linting rules per Vite best practice

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    7f10420 View commit details
    Browse the repository at this point in the history

  12. Apply updated formatting

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    d1138dd View commit details
    Browse the repository at this point in the history

  13. eslint: restore common react/* linting rules

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c8f04cf View commit details
    Browse the repository at this point in the history

  14. eslint: restore recommended rules.

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    8a72be2 View commit details
    Browse the repository at this point in the history

  15. eslint: restore some of the typescript-eslint basic rules

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    9a12c12 View commit details
    Browse the repository at this point in the history

  16. eslint: apply linting to .cjs files; restore additional typescript-es… 

    …lint rules
    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    035b27e View commit details
    Browse the repository at this point in the history

  17. restore the remaining typescript-eslint rules that we can

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    bc0a9b4 View commit details
    Browse the repository at this point in the history

  18. s/MapBox/Mapbox

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    110c4a3 View commit details
    Browse the repository at this point in the history

  19. eslint rules triage complete & global yarn fmt

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c7fcd9f View commit details
    Browse the repository at this point in the history

  20. Updates to tsconfig.json

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    0d5e35d View commit details
    Browse the repository at this point in the history

  21. gitignore tsbuildinfo

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    7fb8761 View commit details
    Browse the repository at this point in the history

  22. fix most of the typescript errors; add tsx to 'check' command; add pr… 

    …ettier caching; sundry
    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c904202 View commit details
    Browse the repository at this point in the history

  23. Flag the remaining typescript build errors with todo's so we have a c… 

    …lean build
    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    154ee9b View commit details
    Browse the repository at this point in the history

  24. add preview:core to package.json

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    6eb3fdb View commit details
    Browse the repository at this point in the history

  25. (repair webworkers) replace promise.resolve().then with setTimeout 

    - Turns out promise.resolve().then() doesn't actually accomplish the equivalent of a setImmediate.  I was mislead by something online, oh well...  setTimeout works.
- The main simulation worker was breaking when you used the 'run' functionality because the thread would lock. A setTimeout (and previously, setImmediate) was needed to allow other events in the thread.
    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    526ef58 View commit details
    Browse the repository at this point in the history

  26. Spacing fix in husky's pre-push

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    f62782f View commit details
    Browse the repository at this point in the history

  27. Update vercel.json for new vite build

    @judeallred
    judeallred committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    8da4a2e View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Remove auto-types.ts and hardcode its relevant items into types.ts 

    This file was ignored and persisted across branches, thus causing fresh checkouts to break (as Vite no longer generates this) but existing checkouts to act "normal".  I've removed the files and its special cases entirely, and added its contents into types.ts.

This now repairs the build. Next up is pruning out the unused generated items and only keeping the relevant ones.
    @judeallred
    judeallred committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    b3f9e0f View commit details
    Browse the repository at this point in the history

  2. Remove unused types from types.ts

    @judeallred
    judeallred committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    5e78ed0 View commit details
    Browse the repository at this point in the history

  3. adjust package.json lint and fmt commands to work cross-platform

    @judeallred
    judeallred committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    2e69841 View commit details
    Browse the repository at this point in the history

  4. .gitignore .vercel

    @judeallred
    judeallred committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    91e2f46 View commit details
    Browse the repository at this point in the history