Added caching to the proxy part of the BlueZManager class #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alling dbus very often causes extreme lag and is advised against by the dbus creators
* Added version file
|
@gvheertum Hi, i just created a fork of this repo. If you make a PR I'll merge it. The URL is https://github.com/vestervang/DotNet-BlueZ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in Issue #6 excessive calling of the GetProxiesAsync will hang up sometimes. I pinpointed the issue to the calls to the GetManagedObjects on the dbus. The manual of dbus states that this is a hefty call and should not be done very often.
I changed to code to do an initials scan and subscribe to the add/remove events and update the cache at the moment an event is raised. This improved the overall performance of the GetProxiesAsync and causes the code to no longer hang on the GetManagedObjects. In duration tests we've seen no issues with missed add/remove events what so ever.