Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SQL features in beam-sqlite. #698

Closed
wants to merge 11 commits into from

Conversation

amano-kenji
Copy link

This was recreated from #655 after accidentally deleting my beam fork along with other repositories.

  • T152, T152 // IS (NOT) DISTINCT FROM
  • FULL OUTER JOIN
  • SQL2003 Null Ordering
  • Common Table Expression
  • Window functions
  • Filter clause // FILTER (WHERE ...)

It closes #648

@amano-kenji
Copy link
Author

Any interest in merging this? If it is going to be merged, I would fix the conflict.

@LaurentRDC
Copy link
Member

Hey @amano-kenji , I'm happy to review and merge once you resolve the conflicts

@LaurentRDC LaurentRDC self-requested a review October 9, 2024 18:24
@LaurentRDC
Copy link
Member

One major weakness of this pull request is the lack of additional tests.
I'm not a SQLite user, so it would be nice to have a few tests to ensure that the new features are indeed supported.

@amano-kenji
Copy link
Author

I don't use these features in SQLite, and I decided to cut non-essential coding out of my life. I may write small scripts here and there, but that's about it.

Thus, I close this.

@amano-kenji amano-kenji closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLite supports full join, is not distinct from, FILTER (WHERE ...), and CTEs.
2 participants