Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few FFI bindings #17

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

arybczak
Copy link
Contributor

@arybczak arybczak commented Aug 9, 2024

They were not correctly defined and it manifested in compilation errors with GCC 14 which enabled -Werror=incompatible-pointer-types.

They were not correctly defined and it manifested in compilation errors with GCC
14 which enabled -Werror=incompatible-pointer-types.
@arybczak
Copy link
Contributor Author

@ldillinger Ping. This is important since without this the botan-bindings package doesn't compile with GCC 14.

@ldillinger
Copy link
Collaborator

@arybczak Apologies for the delay, I've been rather heavily otherwise engaged! I'll prioritize this today.

@ldillinger ldillinger merged commit 99de68c into haskell-cryptography:main Aug 27, 2024
6 of 12 checks passed
@ldillinger
Copy link
Collaborator

I see, I doubled up on the FunPtr in both the function and type definitions. Thank you for catching that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants