simpleHTTP: Catch exception from failHTTPS and turn it into Result #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openStream can fail for example when connecting to host fails. Catch this and return error as Result with message from IOException instead. While there, remove unnecessary normalizeRequest since it's called in simpleHTTP_. Fixes #92
failHTTPS throws Exception when trying to connect to HTTPS. Catch this and return error as Result with message from IOException instead. Fix unit test to comply with changed behaviour. Fixes #77
oherrala
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failHTTPS throws Exception when trying to connect to HTTPS. Catch this and return error as Result with message from IOException instead.
Fix unit test to comply with changed behaviour.
This pull request builds on top of pull request #102 .
Fixes #77