Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cabal: Honour -working-dir flag when running test executables #10725

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

mpickering
Copy link
Collaborator

A simple fix to run the test executable in the -working-dir.

Fixes #10704

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

@sheaf
Copy link
Collaborator

sheaf commented Jan 8, 2025

Excellent, thanks @mpickering. Is there a similar bug in the code for running benchmarks? IIRC that code is very similar.

@mpickering
Copy link
Collaborator Author

Benchmarks look to be fine. I'll extend the test anyway.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ulysses4ever
Copy link
Collaborator

Needs only a merge label now after two reviews.

@Mikolaj
Copy link
Member

Mikolaj commented Jan 10, 2025

@mpickering: would you like to set the merge label? it's a way of saying you don't want to add anything else to the PR (label needs-review only says it's ready enough to be reviewed).

@mpickering mpickering added the merge me Tell Mergify Bot to merge label Jan 10, 2025
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Jan 10, 2025
A simple fix to run the test executable in the `-working-dir`.

Fixes haskell#10704
@mergify mergify bot merged commit 8e35c5d into haskell:master Jan 12, 2025
46 checks passed
Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-backport 3.14 merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal test doesn't change to package directory
5 participants