Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: properly update metadata on nigthly releases #10756

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

TeofilC
Copy link
Collaborator

@TeofilC TeofilC commented Jan 17, 2025

Previously only the artifacts would be replaced and all the other
information would stay the same as the original nightly release.

Resolves #10537

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another try! Why draft though? LGTM as is... Did you have a chance to test it on your fork? That's what I did in the past (although, I somehow thought it worked when in fact it didn't).

@TeofilC
Copy link
Collaborator Author

TeofilC commented Jan 20, 2025

It's draft because I was testing it on my fork and it turns out that despite the names of the settings, this action also doesn't do the right thing. I'm going to try out one of the other ones from the ticket.

I think this one has a good chance of working: https://github.com/marketplace/actions/nightly-release . It's used by logseq and I can see that their releases seem to update properly, although it was last updated in December so that's a bit odd

@TeofilC
Copy link
Collaborator Author

TeofilC commented Jan 20, 2025

The updated version of this seems to be working on my fork 🎉 https://github.com/TeofilC/cabal/releases

@TeofilC TeofilC marked this pull request as ready for review January 20, 2025 18:10
@TeofilC TeofilC changed the title ci: update the existing nightly prerelease ci: properly update metadata on nigthly releases Jan 20, 2025
@ulysses4ever
Copy link
Collaborator

@geekosaur could you review this?

@ulysses4ever
Copy link
Collaborator

@ffaf1 maybe?

Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good as far as I can see.

@ulysses4ever
Copy link
Collaborator

Thanks Francesco!

@TeofilC do you want to put the merge label?

@TeofilC TeofilC added the merge me Tell Mergify Bot to merge label Jan 24, 2025
@TeofilC
Copy link
Collaborator Author

TeofilC commented Jan 24, 2025

Sure. 🤞 it works this time!

@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Jan 24, 2025
Previously only the artifacts would be replaced and all the other
information would stay the same as the original nightly release.

Resolves #10537
@mergify mergify bot merged commit eda072d into master Jan 26, 2025
53 checks passed
@mergify mergify bot deleted the wip/teo/T10537 branch January 26, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal-head prerelase date and commit are not updated
3 participants