Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add marked output to cabal list-bin #8622

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Conversation

Cmdv
Copy link
Collaborator

@Cmdv Cmdv commented Nov 30, 2022

Fixes #8400

unsure if using the correct service functions to do this 😄


Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

@Cmdv Cmdv force-pushed the 8400-cabal-list-bin branch from 15e8237 to 881543f Compare November 30, 2022 16:20
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution!

@ulysses4ever
Copy link
Collaborator

Something funny hit the macos-9.4 job: https://github.com/haskell/cabal/actions/runs/3585117132/jobs/6056940056 Will try to restart, but looks like a CI issue. Definitely, nothing to do with the patch.

@ulysses4ever
Copy link
Collaborator

Oh, this is tracked at #6489

@Cmdv
Copy link
Collaborator Author

Cmdv commented Dec 2, 2022

ah weird I wasn't able to reproduce it locally either and I'm on macos 9.4.2 🤔

@ulysses4ever
Copy link
Collaborator

Okay, just restarting seemed to have helped. As the author of the issue this is addressing, I invite @andreasabel to review...

@ulysses4ever ulysses4ever changed the title add marked output to cabal list bin add marked output to cabal list-bin Dec 2, 2022
Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I guess this is what I wanted!

@andreasabel
Copy link
Member

I am a bit puzzled that no test had to be updated. Apparently, we are lacking tests for list-bin.

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Dec 10, 2022
@kokobd kokobd force-pushed the 8400-cabal-list-bin branch from 881543f to b2be49c Compare December 10, 2022 08:39
@mergify mergify bot merged commit 63b0f6f into haskell:master Dec 10, 2022
@jneira
Copy link
Member

jneira commented Jan 3, 2023

I am a bit puzzled that no test had to be updated. Apparently, we are lacking tests for list-bin.

And a test should had been added this time imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-test cabal-install: cmd/list-bin merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal list-bin does not produce marked output
4 participants