-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add marked output to cabal list-bin
#8622
Conversation
15e8237
to
881543f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the contribution!
Something funny hit the macos-9.4 job: https://github.com/haskell/cabal/actions/runs/3585117132/jobs/6056940056 Will try to restart, but looks like a CI issue. Definitely, nothing to do with the patch. |
Oh, this is tracked at #6489 |
ah weird I wasn't able to reproduce it locally either and I'm on macos 9.4.2 🤔 |
Okay, just restarting seemed to have helped. As the author of the issue this is addressing, I invite @andreasabel to review... |
cabal list bin
cabal list-bin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I guess this is what I wanted!
I am a bit puzzled that no test had to be updated. Apparently, we are lacking tests for |
881543f
to
b2be49c
Compare
And a test should had been added this time imo |
Fixes #8400
unsure if using the correct service functions to do this 😄
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!