Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow building cabal-install-3.10 with ghc-9.6 #8964

Merged
merged 1 commit into from
May 27, 2023
Merged

Conversation

juhp
Copy link
Collaborator

@juhp juhp commented May 22, 2023

bump a few bounds to allow building with ghc-9.6

Yes cabal-install-3.10 ought to be buildable with 9.6...

@Kleidukos Kleidukos self-requested a review May 22, 2023 09:52
@juhp juhp changed the title allow building with ghc-9.6 allow building 3.10 with ghc-9.6 May 22, 2023
@juhp juhp changed the title allow building 3.10 with ghc-9.6 allow building cabal-install-3.10 with ghc-9.6 May 22, 2023
@juhp
Copy link
Collaborator Author

juhp commented May 22, 2023

Btw I will add or force 9.6 into the GH actions...

@Kleidukos
Copy link
Member

Kleidukos commented May 22, 2023

@juhp yeah about that… #8901 :')
edit: and more specifically #8901 (comment)

@juhp
Copy link
Collaborator Author

juhp commented May 22, 2023

Ugh 😢

@juhp
Copy link
Collaborator Author

juhp commented May 22, 2023

Anyway it "builds on my machine" ;o)

@juhp
Copy link
Collaborator Author

juhp commented May 22, 2023

So I reverted the GH workflows changes

@juhp
Copy link
Collaborator Author

juhp commented May 22, 2023

So it would be nice if someone would approve this,
then it should be possible to build 3.10 with ghc-9.6 as God intended. :-)

But of course the more important thing would be to please do the corresponding revision on Hackage.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We still need to work on adding 9.6 CI, sadly (e.g. #8901).

@Mikolaj, Hackage revision? Or will @Kleidukos do the revision as a champion for 3.10.2? @Kleidukos do you have permissions?

@ulysses4ever ulysses4ever added merge me Tell Mergify Bot to merge and removed attention: needs-review labels May 22, 2023
@Kleidukos
Copy link
Member

I don't think I do yet!

@ulysses4ever
Copy link
Collaborator

We should fix it since you're gonna need it anyways for 3.10.2...

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label May 24, 2023
@ulysses4ever
Copy link
Collaborator

The merge bot config currently handles only the master branch, so merging manually since the delay has passed.

@ulysses4ever ulysses4ever merged commit 21a68a3 into haskell:3.10 May 27, 2023
@ulysses4ever
Copy link
Collaborator

@Mikolaj could you give Hecate permissions to do corresponding version bumps on Hackage? He'll need it for 3.10.2 anyway.

@juhp juhp deleted the 3.10 branch May 28, 2023 13:54
@Mikolaj
Copy link
Member

Mikolaj commented May 29, 2023

@ulysses4ever, @Kleidukos, yes, absolutely. Actually, @Kleidukos has the permissions as of now, I see.

@Kleidukos Kleidukos self-assigned this May 29, 2023
@Kleidukos
Copy link
Member

done!

@Kleidukos Kleidukos removed their assignment May 29, 2023
@juhp
Copy link
Collaborator Author

juhp commented May 30, 2023

Thanks!
But we also need a revision of https://hackage.haskell.org/package/cabal-install-solver-3.10.1.0

@Kleidukos
Copy link
Member

@juhp should be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants