Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more bytestring like functions #202

Closed
wants to merge 5 commits into from
Closed

Add more bytestring like functions #202

wants to merge 5 commits into from

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Oct 14, 2023 •
edited
Loading

This introduce bytestring-like functions (substrings, predicates, searching, etc.) to System.OsString, System.OsString.Windows and System.OsString.Posix.

Relevant for pcapriotti/optparse-applicative#65

Functions added:

  • snoc
  • cons
  • last
  • tail
  • uncons
  • head
  • init
  • unsnoc
  • null
  • length
  • map
  • reverse
  • intercalate
  • foldl
  • foldl'
  • foldl1
  • foldl1'
  • foldr
  • foldr'
  • foldr1
  • foldr1'
  • all
  • any
  • concat
  • replicate
  • unfoldr
  • unfoldrN
  • take
  • takeEnd
  • takeWhileEnd
  • takeWhile
  • drop
  • dropEnd
  • dropWhileEnd
  • dropWhile
  • break
  • breakEnd
  • span
  • spanEnd
  • splitAt
  • split
  • splitWith
  • stripSuffix
  • stripPrefix
  • isInfixOf
  • isPrefixOf
  • isSuffixOf
  • breakSubstring
  • elem
  • find
  • filter
  • partition
  • index
  • indexMaybe
  • (!?)
  • elemIndex
  • elemIndices
  • count
  • findIndex
  • findIndices

@hasufell hasufell marked this pull request as draft October 14, 2023 11:44
@hasufell hasufell force-pushed the bytestring-functions branch from 3be088c to 399f127 Compare October 15, 2023 07:49
@hasufell hasufell marked this pull request as ready for review October 15, 2023 07:50
@hasufell hasufell mentioned this pull request Oct 15, 2023
Closed
@hasufell hasufell force-pushed the bytestring-functions branch from 399f127 to 1129f72 Compare October 15, 2023 08:01
Bodigrim
Bodigrim reviewed Oct 15, 2023
View reviewed changes
System/OsString/Common.hs Outdated Show resolved Hide resolved
@hasufell hasufell force-pushed the bytestring-functions branch 2 times, most recently from b0e7018 to 0b6d702 Compare October 16, 2023 10:27
clyring
clyring reviewed Oct 16, 2023
View reviewed changes
System/OsString.hs Outdated Show resolved Hide resolved
System/OsString/Common.hs Outdated Show resolved Hide resolved
System/OsString/Common.hs Outdated Show resolved Hide resolved
System/OsString/Common.hs Outdated Show resolved Hide resolved
@hasufell hasufell requested a review from clyring October 16, 2023 16:40
clyring
clyring reviewed Oct 16, 2023
View reviewed changes
System/OsString/Internal.hs Outdated Show resolved Hide resolved
System/OsString/Common.hs Outdated Show resolved Hide resolved
System/OsString/Common.hs Outdated Show resolved Hide resolved
@hasufell hasufell requested review from clyring and Bodigrim October 19, 2023 09:18
@hasufell hasufell force-pushed the bytestring-functions branch from fbbf47f to 97fc2e3 Compare October 19, 2023 10:30
@hasufell hasufell mentioned this pull request Oct 19, 2023
Closed
@hasufell hasufell mentioned this pull request Oct 20, 2023
Closed
@hasufell hasufell mentioned this pull request Nov 18, 2023
Open
@hasufell hasufell closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clyring clyring clyring approved these changes

@Bodigrim Bodigrim Bodigrim approved these changes

@sjakobi sjakobi Awaiting requested review from sjakobi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hasufell @Bodigrim @clyring