Support the newly added par_balanced_copied field. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a small eventlog which contains the new field to the test suite? |
|
Done. The |
Signed-off-by: HE, Tao <[email protected]>
maoe
requested changes
May 15, 2019
| parBalancedCopied <- return Nothing | ||
| return GCStatsGHC{ gen = fromIntegral gen | ||
| , parNThreads = fromIntegral parNThreads | ||
| , ..} |
There was a problem hiding this comment.
I think it's better to set parBalancedCopied here rather than using return Nothing above:
Suggested change
| , ..} | |
| , parBalancedCopied = Nothing | |
| , ..} |
There was a problem hiding this comment.
Done. Thanks for the suggestion.
src/GHC/RTS/Events/Binary.hs
Outdated
| parNThreads <- get :: Get Word32 | ||
| parMaxCopied <- get :: Get Word64 | ||
| parTotCopied <- get :: Get Word64 | ||
| parBalancedCopied <- fmap Just (get :: Get Word64) |
There was a problem hiding this comment.
Same here:
Suggested change
| parBalancedCopied <- fmap Just (get :: Get Word64) | |
| parBalancedCopied <- get :: Get Word64 | |
| return GCStatsGHC{ gen = fromIntegral gen | |
| , parNThreads = fromIntegral parNThreads | |
| , parBalancedCopied = Just parBalancedCopied | |
| , .. } |
|
LGTM, thanks! |
|
Just uploaded https://hackage.haskell.org/package/ghc-events-0.9.0. |
|
@maoe Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a fixed size parser that can handle the newer version of
GCStatsGHCEvent.Fixes #31 and #41.