Fix support for GHCJS_BROWSER compilation flag of GHC #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was pushing code from gitlab, there seem to be some ghost commits in the history... |
Bodigrim
reviewed
Jan 1, 2025
| function h$js_futimes(fd,atime,mtime) { | ||
| #ifdef GHCJS_BROWSER | ||
| throw "h$js_futimes unsupported"; | ||
| #else | ||
| if (!h$isNode()) { |
There was a problem hiding this comment.
Could it be
Suggested change
| if (!h$isNode()) { | |
| if (!h$isNode() || defined(GHCJS_BROWSER)) { |
?
There was a problem hiding this comment.
Not sure what you mean, we want a preprocessor-level if, not a runtime-level if here; sources are preprocessed via emcc before compilation.
There was a problem hiding this comment.
In other words if ghc is compiled with -DGHCJS_BROWSER then h$isNode() is undefined at runtime and we don't want to include this code at all.
|
Please rebase cleanly on |
|
ping @Swordlash |
hasufell
force-pushed
the
wip/swordlash/ghcjs_browser_fix
branch
from
f0bebdd to
b9b134d
Compare
|
LGTM. @luite Could you review it too please? |
|
Thanks @hasufell :) |
|
I'm going to close this PR for now since we agreed to remove the macro altogether. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://gitlab.haskell.org/ghc/ghc/-/issues/25613#note_602248
When compiling
ghcunder GHCJS_BROWSER, all the environment checking code should be removed by the preprocessor. This is not the case for thejsbitsof theunixlibrary, which causes troubles for Google Closure Compiler and bundlers. This PR adds missing directives.