Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Apache Phoenix config docs #903

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pranshi06
Copy link
Contributor

Description 📝

Quick Links 🚀

Assertion Tests 🤖

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 17, 2025

DX: Assertion Testing

✅ Diff

The documentation PR clearly details the configuration aspects of the Apache Phoenix connector. The JSON examples are comprehensive and provide good clarity on how to populate the configuration fields. The JDBC URL section, in particular, clearly explains both how to use a literal connection string as well as an environment variable, which is important for security and configurability. The explanation of properties like JDBC Properties, Tables, and Native Queries is elaborate and seems to cover all necessary aspects.

✅ Integrated

The PR effectively integrates into the larger body of documentation by adding Apache Phoenix as a new entry in the connectors section. The other connector categories have been updated with new positions to accommodate the addition of Apache Phoenix which maintains the ordered list structure. Additionally, the PR includes an update to the main connectors' index page to include a reference to the newly added Apache Phoenix documentation, ensuring users can easily navigate to this new content.

@hasura-bot
Copy link
Contributor

@pranshi06 Thanks for your PR! I've assigned @seanparkross to review it.

Copy link

cloudflare-workers-and-pages bot commented Feb 17, 2025

Deploying ddn-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ac2437d
Status: ✅  Deploy successful!
Preview URL: https://c5c80a20.v3-docs-eny.pages.dev
Branch Preview URL: https://pranshi-docs-phoenix-config.v3-docs-eny.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants