Doc 355 - client doc updates #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
oliverhowell
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Thanks @amandalindsay it's looking good - left some specific suggestions that affect a few of the pages
yuce
approved these changes
Jan 24, 2025
yuce
reviewed
Jan 24, 2025
Co-authored-by: Oliver Howell <[email protected]>
Co-authored-by: Oliver Howell <[email protected]>
Co-authored-by: Oliver Howell <[email protected]>
Co-authored-by: Oliver Howell <[email protected]>
Co-authored-by: Oliver Howell <[email protected]>
Co-authored-by: Oliver Howell <[email protected]>
|
@oliverhowell Please take a look at the tweaks I made as a result of your comments. Hopefully we're good! |
oliverhowell
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
LGTM @amandalindsay thanks for addressing suggestions
You'll need to change from Draft PR too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the individual client doc topics with improved descriptions based on what's already there, plus information from the main HZC website (e.g. https://hazelcast.com/developers/clients/cplusplus/).
Note that the Java client topic will be done in a separate PR (this is to avoid merge conflicts resulting from changes for Doc-294)