Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize Python compatibilities and bump lspopt version #10

Merged
merged 12 commits into from
Jan 7, 2025

Conversation

remrama
Copy link
Contributor

@remrama remrama commented Jan 7, 2025

Just upgraded overall compatibilities and thought I would bump the version so that it would be easier to toss this onto PyPI. Changes listed below, copy/pasted from what I put in the CHANGELOG.md with some added links for context:

[1.4.0] - 2025-01-07

Added

Removed

  • Support for Python 3.7 and 3.8
  • Unused imports

@hbldh hbldh self-assigned this Jan 7, 2025
@hbldh
Copy link
Owner

hbldh commented Jan 7, 2025

Sorry, I forgot to publish it after merging the last PR... Thank you for continuing to push this.

There was an issue with 3.7 and 3.8 which I was planning on fixing first; but I think in this instance it is more prudent to just get it out instead...

I will merge this and rewrite the setup.py to a setup.cfg instead, to be more in step with the newer developments in Python.

@hbldh hbldh merged commit 6a3508c into hbldh:master Jan 7, 2025
24 checks passed
@hbldh
Copy link
Owner

hbldh commented Jan 7, 2025

@remrama Version 1.4.0 has now been published to PyPI. Please test it, since I have changed some parts of the publishing solution. I think everything is there, but get back to me if something does not work all of a sudden.

@remrama remrama deleted the develop branch January 7, 2025 17:24
@remrama
Copy link
Contributor Author

remrama commented Jan 7, 2025

Thanks @hbldh, I just tested with a reinstall and quick usage with v1.4 and everything went smooth. Much appreciated 👍

@hbldh
Copy link
Owner

hbldh commented Jan 7, 2025

Once again, thank you so much for this effort! I appreciate this, even though I forgot to upload it...

This code is actually from my Master's thesis. I had the author of the multitaper paper as a teacher and she wanted me to use it for analysing eye tracking data. It is nice to know that it is of some use for other people as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants