Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete selected clip #175

Merged
merged 3 commits into from
Feb 28, 2023
Merged

delete selected clip #175

merged 3 commits into from
Feb 28, 2023

Conversation

krizmyass
Copy link
Contributor

added option to delete selected clip by long pressing right button on page_playback

@krizmyass krizmyass marked this pull request as draft February 24, 2023 17:39
@krizmyass krizmyass marked this pull request as ready for review February 24, 2023 20:16
@bkleiner
Copy link
Contributor

bkleiner commented Feb 24, 2023

i am fine with this in the interims, but ultimately i think we want a solution like #98 to access more advanced options in a given menu. having 5 different keystrokes to trigger different options is gonna get confusing quick.

@krizmyass
Copy link
Contributor Author

i am fine with this in the interims, but ultimately i think we want a solution like #98 to access more advanced options in a given menu. having 5 different keystrokes to trigger different options is gonna get confusing quick.

Great. I will work on a context menu.

src/ui/page_playback.c Outdated Show resolved Hide resolved
src/ui/page_playback.c Outdated Show resolved Hide resolved
src/ui/page_playback.c Outdated Show resolved Hide resolved
src/ui/page_playback.c Outdated Show resolved Hide resolved
@bkleiner
Copy link
Contributor

finally got around to testing this - seems to work fine.

@bkleiner bkleiner merged commit bcdd8c5 into hd-zero:main Feb 28, 2023
@krizmyass krizmyass deleted the delete_clip_option branch February 28, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants