-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a beep once goggles are up and running. #395
base: main
Are you sure you want to change the base?
Conversation
Suggestion: make it an option in the gui? |
Yes, there may be people who don't like beep. |
I'll do it once I have some free time. |
much desired option. |
There's already a beep when my goggles boot up to HDZero thanks to the expansion module. The expansion module is set to automatically switch off if not used, and the goggles beep as soon as the power to the expansion module is toggled. Could this feature be further improved by having the goggles do a beep when the source is changed? This means it will beep on startup, and when the source is changed, to indicate the switch was succesful. Not sure on which page we could add the option to enable/disable the beep though. Perhaps three options:
|
addition of |
@nerdCopter why not? I tested it with WSL, it should work in native Linux as well. Very useful if you need to debug something. |
Because PRs are better when they focus on just one thing/area. So while, useful, that change does not relate to the rest of the PR and its overall area of focus. It would probably be better to have that in a in a separate PR, adding just that functionality. Smaller/single focus PRs are easier and quicker to review, and thus more likely to get merged sooner. i.e. that might have been merged a couple of months ago now if it wasn't part of this PR ;) |
HDZero Goggle take around 20 seconds to start up.
This PR makes goggles beep once they started up, so user doesn't have to check visually.