Fix erlang:get_stacktrace() warning that causes building erlport to fail on OTP 21

[jeffutter]

This warning, introduced in OTP 21 is causing things that depend on erlport to fail to build. Normally a warning wouldn't have such an impact but the rebar.config has {erl_opts, [debug_info, warnings_as_errors]}. which turns the warning into a compile error.

I am not an erlang expert, feedback is welcome on the PR.

[callmeahab]

Hey @jeffutter I merged your changes and tried running but I get this error:

/usr/local/opt/python/bin/python3.6: No module named erlport.cli
[error] GenServer #PID<0.552.0> terminating
** (stop) {:port_closed, :epipe}
Last message: {:EXIT, #Port<0.31>, :epipe}
State: {:state, :infinity, 0, #Port<0.31>, [{1, {{#PID<0.548.0>, #Reference<0.3350477430.3634364418.242219>}, :undefined}}], []}

I don't have erlport installed through pip, so thats not making a problem.

[jeffutter]

@callmeahab how are you including erlport into your project? I have run into a similar issue when using it from elixir via an updated export branch pulling in erlport from this github branch. I think there is something in the erlport build process when packaging it up for hex/rebar that puts those dependencies in place and it doesn't work when pulling in the library from github.

[callmeahab]

@jeffutter Yeah, I'm using it in a phoenix app with export. Is the only option to downgrade OTP?

[ghost]

@jeffutter Your fix seems to work fine with OTP 21 for me
@callmeahab This looks familiar and might be a different issue. Have you looked at #44 ?

[jeffutter]

I believe the issues with export will be resolved when this PR is merged, a new release is cut and export is pointed at that release.

[artjimlop]

Seems legit 🚀

[jeffutter]

Any chance of getting this merged?

[callmeahab]

@amarandon I don't have the pip package installed, so that's not the reason it fails, something in the build process like @jeffutter said.

This is now becoming a real issue since elixir 1.7 no longer works with OTP 20. Is there any chance of getting this branch merged?

[junjizhi]

Also hoping this gets merged soon. I upgraded our project to elixir 1.7 and breaks erlport.

[jeffutter]

I don't mean to offend, but I'm wondering if @feng19 (https://github.com/feng19/erlport) can pull this PR into his fork and release a new version to hex.pm since he is the maintainer of the hex package and it seems that development over here has stalled.

Does anyone have an idea how to reach out to him?

[junjizhi]

@jeffutter I just emailed @feng19 about this.

[jeffutter]

@junjizhi Thank you for letting me know. I had just pasted his email address into a new mail to do the same thing :)

[feng19]

Hi, I already merge #44 and #39, Are there other PR that need to be merged? @jeffutter @junjizhi

[jeffutter]

@feng19 this PR, #47 to support OTP 21. Thank you.

[feng19]

PS. Anyone wants to maintain it together, I can add him to the owner list.

[feng19]

#44 already merge this PR,So I will just merge #44

[jeffutter]

@feng19 oh yes I see that now. Thanks.

As far as helping with maintainership. I would be glad to help. Our use of erlport is pretty simple, I'm not sure I would regularly see many of the edge cases that others run into but I would be glad to help where I can.

[feng19]

I already publish a new version(v0.10.0) to hex, @jeffutter Give me your email registered on the hex.pm and I add you to the owner list.

[jeffutter]

@feng19 [email protected] thanks.

[feng19]

OK, @jeffutter

[filmor]

@feng19 @jeffutter I've created a new organisation and invited both of you and uploaded the current master from feng19's fork. I'd like to help maintaining.

[jeffutter]

In case anyone finds this and is looking for the new repo, it is over here: https://github.com/erlport/erlport