-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cocotb #175
Open
rw1nkler
wants to merge
2
commits into
hdl:main
Choose a base branch
from
antmicro:46586-update-cocotb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update Cocotb #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump Cocotb to the version supporting specifying timescale and dumping waveforms using Icarus Verilog. Internal-tag: [#46586] Signed-off-by: Robert Winkler <[email protected]>
QuantamHD
approved these changes
Aug 22, 2023
rw1nkler
force-pushed
the
46586-update-cocotb
branch
from
August 23, 2023 07:29
65880f2
to
05fdf9c
Compare
I pushed again main changes to force another CI run because something seemed to be stuck |
Provide a way to specify timescale and make waves option available for a Cocotb Runner build function. Internal-tag: [#46586] Signed-off-by: Robert Winkler <[email protected]>
rw1nkler
force-pushed
the
46586-update-cocotb
branch
from
August 24, 2023 07:46
05fdf9c
to
8029db6
Compare
@QuantamHD, could you provide more information on why the CI is failing? I don't have access to the logs |
Here's the full log
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates Cocotb to a version that supports specifying
timescale
with Cocotb Runner and includes changes to allow the use of thewaves
attribute for the Icarus Verilog simulator.The changes related to timescale may be useful for users of auto-generated code, that sometimes does not have
timescale
specified in the sources. The additionalwaves
attribute used together with Icarus Verilog removes the need for a separate file with$dumpfile
and$dumpvars
commands.CC @proppy