OpenROAD: Fix version string in binary #374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
git describe
is failing within the OpenROAD build which leads to the version number compiled into the binary falling back to a hash which doesn't work well for version checking.https://github.com/hdl/conda-eda/actions/runs/8012258777/job/21887187187#step:5:2091
The reson seems to be that cmake is called with
-DCMAKE_FIND_ROOT_PATH
such thatfind_package(Git)
fails. Easiest solution seems to be to just add git to the build requirements, which this patch does. Alternatively we could probably passGIT_EXECUTABLE
to cmake.Fix #365