Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenROAD: Fix version string in binary #374

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

ubfx
Copy link
Contributor

@ubfx ubfx commented Feb 23, 2024

Currently git describe is failing within the OpenROAD build which leads to the version number compiled into the binary falling back to a hash which doesn't work well for version checking.

https://github.com/hdl/conda-eda/actions/runs/8012258777/job/21887187187#step:5:2091

  23:23:44 | CMake Warning at CMakeLists.txt:98 (message):
  23:23:44 |   OpenROAD git describe failed, using sha1 instead

The reson seems to be that cmake is called with -DCMAKE_FIND_ROOT_PATH such that find_package(Git) fails. Easiest solution seems to be to just add git to the build requirements, which this patch does. Alternatively we could probably pass GIT_EXECUTABLE to cmake.

Fix #365

@ubfx
Copy link
Contributor Author

ubfx commented Feb 23, 2024

Looks like this worked 🎉

https://github.com/hdl/conda-eda/actions/runs/8015700461/job/21896297577?pr=374#step:5:2239

06:57:23 | -- OpenROAD version: 2.0-12327-g933ae804c

image

cc @proppy

@proppy
Copy link
Contributor

proppy commented Feb 23, 2024

Thanks for figuring that out!

@proppy proppy merged commit 7331df7 into hdl:master Feb 23, 2024
75 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenROAD version string missing git describe output
2 participants