Don't override col_cls in DynamicTable.add_column #1091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Issue: If a user extends
DynamicTableRegion
orEnumData
and tries to create a column with that subclass, using thetable
orenum
keyword args, their subclass argument gets replaced with the baseDynamicTableRegion
orEnumData
classes.Solution: Use the passed col_cls. If not provided, then use the base
DynamicTableRegion
orEnumData
classes.TODO: Add a quick test
Checklist
CHANGELOG.md
with your changes?