-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow override of constructor args and object attrs to return None #1167
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1167 +/- ##
==========================================
+ Coverage 88.88% 88.90% +0.02%
==========================================
Files 45 45
Lines 9835 9835
Branches 2795 2795
==========================================
+ Hits 8742 8744 +2
+ Misses 776 775 -1
+ Partials 317 316 -1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Oliver Ruebel <[email protected]>
This causes a few errors in PyNWB that I will investigate. |
Is this PR okay to review or should I wait for the PyNWB errors. |
Please wait to merge. I haven't had time to look through these yet. If it does not make it in this upcoming release, that is OK. |
Motivation
Fix #178
Checklist
CHANGELOG.md
with your changes?