Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when using colon for container name #1202

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

stephprince
Copy link
Contributor

@stephprince stephprince commented Nov 7, 2024

Motivation

Fix hdmf-dev/hdmf-zarr#219.

TODO:

  • add test that no error occur in construct mode

How to test the behavior?

from pynwb.testing.mock.file import mock_NWBFile
from pynwb.image import TimeSeries


nwbfile = mock_NWBFile()
time_series = TimeSeries(name="Name: name", rate=1.0, data=[1, 2, 3], unit="unit")

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (be602e5) to head (01550f8).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1202   +/-   ##
=======================================
  Coverage   89.12%   89.12%           
=======================================
  Files          45       45           
  Lines        9944     9944           
  Branches     2825     2825           
=======================================
  Hits         8863     8863           
  Misses        762      762           
  Partials      319      319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephprince stephprince marked this pull request as ready for review November 7, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing a name with colon : fails in zarr in windows
1 participant