Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing playbook and merging it into Engine directly #60

Merged
merged 3 commits into from
Dec 29, 2024

Conversation

heckj
Copy link
Owner

@heckj heckj commented Dec 28, 2024

Description

  • remove explicit playbook structure and results for playbook

Motivation and Context

resolves #59
resolves #57

How has this been tested?

Maintain all existing tests, and merged playbook execution tests back into engine

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected. Examples include renaming parameters in public API, removing public API, or adding a new parameter to public API without a default value.)

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have run ./scripts/preflight.bash and it passed without errors.

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.98%. Comparing base (de1cbf6) to head (c4e9782).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Formic/Engine/CommandExecutionResult.swift 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   66.78%   65.98%   -0.81%     
==========================================
  Files          24       23       -1     
  Lines        1168     1117      -51     
==========================================
- Hits          780      737      -43     
+ Misses        388      380       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heckj heckj self-assigned this Dec 28, 2024
@heckj heckj merged commit f537c1a into main Dec 29, 2024
2 of 3 checks passed
@heckj heckj deleted the playbook-merge-engine branch December 29, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dump playbook, move multi host, multi cmd into engine directly command to return bool
1 participant