Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking into possibly using this crate for alacritty/alacritty#4299, and during my read over of the code I was a bit surprised to see the
generated.rs
file was a fixed output frombindgen
. I've addedbindgen
as a build dependency and updated thebuild.rs
file accordingly.The main thing I was confused about during the process was the note in the
build.sh
script:in conjunction with the line:
However, it seems that this does in fact work, at least for the one system call I tested directly.