Avoid cross-test config contamination in microprofile/telemetry tes…

…ts (#9685) * Avoid cross-test config contamination * Remove exclusion of test from Windows
helidon-io · Jan 24, 2025 · aaaf65c · aaaf65c
1 parent 30f1bf6
commit aaaf65c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/microprofile/telemetry/pom.xml b/microprofile/telemetry/pom.xml
@@ -152,7 +152,26 @@
                         <configuration>
                             <systemPropertyVariables>
                                 <otel.bsp.schedule.delay>${otel.bsp.schedule.delay}</otel.bsp.schedule.delay>
+                                <otel.sdk.disabled>false</otel.sdk.disabled>
                             </systemPropertyVariables>
+                            <excludes>
+                                <exclude>**/AgentDetectorTest.java</exclude>
+                            </excludes>
+                        </configuration>
+                    </execution>
+                    <execution>
+                        <!--
+                        This test does not need an active OTel SDK so run it separately to prevent it from running first
+                        and leaving other tests with a no-op Otel which will cause them to fail.
+                         -->
+                        <id>agent-detector-tests</id>
+                        <goals>
+                            <goal>test</goal>
+                        </goals>
+                        <configuration>
+                            <includes>
+                                <include>**/AgentDetectorTest.java</include>
+                            </includes>
                         </configuration>
                     </execution>
                 </executions>

diff --git a/...rofile/telemetry/src/test/java/io/helidon/microprofile/telemetry/TestTracerAtStartup.java b/...rofile/telemetry/src/test/java/io/helidon/microprofile/telemetry/TestTracerAtStartup.java
@@ -31,7 +31,6 @@
 class TestTracerAtStartup {
 
     @Test
-    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "https://github.com/helidon-io/helidon/issues/9513")
     void checkForFullFeaturedTracerAtStartup() {
         assertThat("Global tracer from start-up extension",
                    TestExtension.globalTracerAtStartup.unwrap(io.opentelemetry.api.trace.Tracer.class).getClass().getName(),