Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x Remove logback dependency information from core Helidon dependencies/pom.xml (and move it to the examples repo?) #9644

Open
tjquinno opened this issue Jan 9, 2025 · 1 comment · May be fixed by #9649
Open

4.x Remove logback dependency information from core Helidon dependencies/pom.xml (and move it to the examples repo?) #9644

tjquinno opened this issue Jan 9, 2025 · 1 comment · May be fixed by #9649
Assignees
@barchetta
Labels
4.x Version 4.x build logging

Comments

@tjquinno
Copy link
Member

tjquinno commented Jan 9, 2025

Environment Details

  • Helidon Version: 4.x
  • Helidon SE or Helidon MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

The dependencies/pom.xml file contains information about logback. No core components of Helidon depend on logback, although the slf4j module does declare some native image settings using logback item names as strings.

Example apps do depend on a logback component:

  • helidon-examples-logging-slf4j-aot
  • helidon-examples-logging-slf4j

The declaration of the logback dependency management information should be removed from core Helidon's dependencies/pom.xml and would then need to be declared somewhere in the examples repo.
@tjquinno tjquinno added this to Backlog Jan 9, 2025
@github-project-automation github-project-automation bot moved this to Triage in Backlog Jan 9, 2025
@barchetta
Copy link
Member

Yes, we should remove this. We need to keep in mind that doing so could break a customers build if they depend on Helidon's dependency management to manage the version of logback. Since it is simple and not a Java api change it might be OK in a minor release.

@barchetta barchetta mentioned this issue Jan 9, 2025
Closed
@barchetta barchetta self-assigned this Jan 10, 2025
@barchetta barchetta linked a pull request Jan 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barchetta barchetta

Labels
4.x Version 4.x build logging
Projects
Backlog
Status: Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4.x: Don't manage logback version. Use slf4j-bom. barchetta/helidon
2 participants
@barchetta @tjquinno