4.x: Don't manage logback version. Use slf4j-bom. #9649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barchetta
added
dependencies
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dependencies/pom.xml(and move it to the examples repo?) #9644.slf4j-bominstead of managing individual artifacts.org.glassfish:jakarta-elout of "examples" section of dependency management since it is used by Helidon code (microprofile/bean-validation)Note that removing logback version management has the risk of breaking customer's builds if they rely on Helidon to version manage logback (which they shouldn't, but they might). This is not a Java API change and is easily remedied, and we've made these types of changes in minor releases before. This is why I am considering it for a minor release (4.2.0). If we deem this unacceptable then we'll have to make this change in Helidon 5.
Documentation
No change