Have JaxRsService save response headers and, if Jersey does not handle the request, restore the saved headers #9683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
…e the request, restore the saved headers
tjquinno
force-pushed
the
4.x-jaxrsservice-save-headers
branch
from
dec5224 to
fed0002
Compare
barchetta
reviewed
Feb 3, 2025
microprofile/server/src/main/java/io/helidon/microprofile/server/JaxRsService.java
Show resolved
Hide resolved
barchetta
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9675
If
JaxRsService#doHandlefinds that Jersey does not handle a request, it resets the routing and lets the SE request handling have a chance.Resetting the routing also clears any response headers (for example, set by an upstream SE filter).
With this PR,
#doHandlesaves the current response headers and, if Jersey did not handle the request, resets the routing _and restores the saved headers` before handing the request off to SE.The PR also adds an integration test.
Documentation
No impact.