Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid cross-test config contamination in microprofile/telemetry tests #9685

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Avoid cross-test config contamination in microprofile/telemetry tests #9685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
115d4dd
Avoid cross-test config contamination
tjquinno Jan 24, 2025
1477011
Remove exclusion of test from Windows
tjquinno Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions microprofile/telemetry/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,26 @@
<configuration>
<systemPropertyVariables>
<otel.bsp.schedule.delay>${otel.bsp.schedule.delay}</otel.bsp.schedule.delay>
<otel.sdk.disabled>false</otel.sdk.disabled>
</systemPropertyVariables>
<excludes>
<exclude>**/AgentDetectorTest.java</exclude>
</excludes>
</configuration>
</execution>
<execution>
<!--
This test does not need an active OTel SDK so run it separately to prevent it from running first
and leaving other tests with a no-op Otel which will cause them to fail.
-->
<id>agent-detector-tests</id>
<goals>
<goal>test</goal>
</goals>
<configuration>
<includes>
<include>**/AgentDetectorTest.java</include>
</includes>
</configuration>
</execution>
</executions>
Expand Down
1 change: 0 additions & 1 deletion ...rofile/telemetry/src/test/java/io/helidon/microprofile/telemetry/TestTracerAtStartup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
class TestTracerAtStartup {

@Test
@DisabledOnOs(value = OS.WINDOWS, disabledReason = "https://github.com/helidon-io/helidon/issues/9513")
void checkForFullFeaturedTracerAtStartup() {
assertThat("Global tracer from start-up extension",
TestExtension.globalTracerAtStartup.unwrap(io.opentelemetry.api.trace.Tracer.class).getClass().getName(),
Expand Down
Loading