Explicitly filter out proprietary packets in check

helium · Aug 1, 2023 · 3ff196a · 3ff196a
1 parent 6fcfa39
commit 3ff196a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/packet.rs b/src/packet.rs
@@ -118,7 +118,11 @@ impl PacketUp {
     }
 
     pub fn is_uplink(&self) -> bool {
-        Self::parse_frame(Direction::Uplink, self.payload()).is_ok()
+        // An uplinkable packet is a parseable lorawan uplink frame which is not
+        // a proprietary frame
+        Self::parse_frame(Direction::Uplink, self.payload())
+            .map(|frame| !matches!(frame, PHYPayloadFrame::Proprietary(_)))
+            .unwrap_or(false)
     }
 
     pub fn payload(&self) -> &[u8] {