Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support solana addresses for owner and payer #461

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Conversation

madninja
Copy link
Member

@madninja madninja commented Sep 22, 2023

For legacy usage support this supports both helium public keys as well
as solana addresses.

Fixes #460

For legacy usage support this supports both helium public keys as well
as solana addresses.
@madninja
Copy link
Member Author

@jthiller so the new output from the add cli here will now not display the fees since they're all determined by the network.. It'll also display owner and payer as Solana keys instead of the helium equivalent regardless of whether the user passed in legacy helium owner/payer or solana keys.

eg. output:

{
  "address": "helium_key",
  "mode": "dataonly",
  "owner": "solana_key",
  "payer": "solana_key",
  "txn": "xxx"
}

@jthiller
Copy link

Lovely! I'll update the docs

@jthiller
Copy link

jthiller commented Sep 27, 2023

Fixes #457

Edit: sad, I don't seem to be able to link the issue

@jthiller jthiller linked an issue Sep 27, 2023 that may be closed by this pull request
@madninja madninja merged commit f3b52bb into main Oct 3, 2023
11 checks passed
@madninja madninja deleted the madninja/add_keys branch October 3, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Solana accounts in add command. Remove chain fee from add command.
2 participants