Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support invalid details for invalid beacons and witnesses #366

Merged
merged 5 commits into from
Aug 17, 2023
Merged

support invalid details for invalid beacons and witnesses #366

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b62db44
support invalid details for invalid beacons and witnesses
andymck Aug 17, 2023
b8160d4
switch to a oneof
andymck Aug 17, 2023
8576f0f
dedicated invalid details message type
andymck Aug 17, 2023
d9d56fe
review tweaks
andymck Aug 17, 2023
94ae5c4
revert to invalid_details naming
andymck Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/service/poc_lora.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ message lora_valid_witness_report_v1 {
uint32 reward_unit = 5;
}

message invalid_details {
oneof data { string denied = 1; }
madninja marked this conversation as resolved.
Show resolved Hide resolved
}

// tagged invalid beacon report produced by the verifier
message lora_invalid_beacon_report_v1 {
// Timestamp at ingest in millis since unix epoch
Expand All @@ -160,6 +164,9 @@ message lora_invalid_beacon_report_v1 {
/// The asserted elevation of the gateway in AGL ( above ground level)
/// derived from gateway metadata
int32 elevation = 6;
// provides any additional context for invalid reason
// for example the deny list version used as part of the deny list check
invalid_details invalid_details = 7;
madninja marked this conversation as resolved.
Show resolved Hide resolved
}

// tagged invalid witness report produced by the verifier
Expand All @@ -171,6 +178,9 @@ message lora_invalid_witness_report_v1 {
// the participant to which the reason applies,
// which rendered the report as invalid
invalid_participant_side participant_side = 4;
// provides any additional context for invalid reason
// for example the deny list version used as part of the deny list check
invalid_details invalid_details = 5;
madninja marked this conversation as resolved.
Show resolved Hide resolved
}

// tagged verified witness report produced by the verifier
Expand All @@ -196,6 +206,9 @@ message lora_verified_witness_report_v1 {
/// The asserted elevation of the gateway in AGL ( above ground level)
/// derived from gateway metadata
int32 elevation = 10;
// provides any additional context for invalid reason
// for example the deny list version used as part of the deny list check
invalid_details invalid_details = 11;
madninja marked this conversation as resolved.
Show resolved Hide resolved
}

// POC report produced by the verifier
Expand Down
Loading