Add fields to heartbeat and mobile_reward_share files to help understand how rewards are calculated

[bbalser]

In troubleshooting various issues, I realized how valuable having all the multipliers be recorded in the mobile_verifier outputs would be.

[madninja]

I like it since it captures changes over time to these values.. Couple of comments:

1. Floats are pretty evil. Can we use a fixed point?
2. What happens with older data where these fields are not present? Proto semenatics would have these at 0. Is that ok?

[bbalser]

I like it since it captures changes over time to these values.. Couple of comments:

1. Floats are pretty evil. Can we use a fixed point?
2. What happens with older data where these fields are not present? Proto semenatics would have these at 0. Is that ok?

1. Good call, will change those to fixed point
2. Fair point, should we just make version 2 of these messages to avoid that behaviour or is there something else you had in mind?

[madninja]

2. Fair point, should we just make version 2 of these messages to avoid that behaviour or is there something else you had in mind?

Not sure that'll help since you would have to decide what to do with the v1 protos anyway? Are the default 0 not used otherwise? If they're not "normal" values that may be enough to tell the two apart?

[riobah]

1. Is there a planned release date for these changes?
2. the comments in code imply some equation likereward_multiplier = heartbeat_multiplier * location_trust_score_multiplier. In which message is this heartbeat_multiplier?
3. when reward_multiplier is deprecated, does it mean that it will not be maintained and come as 0 immediately?
4. To give full context of the reward calculations, do we need some heartbeat multiplier in the radio_reward message?