Adds usage count msgs to support hip 118 visualization data #428
+87
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcyoung
reviewed
Nov 7, 2024
src/service/poc_mobile.proto
Outdated
Comment on lines
15
to
20
| uint64 service_provider_subscriber_count = 2; | ||
| // Number of unique discovery mapping enabled subscribers active | ||
| // in the hex during the epoch | ||
| uint64 disco_mapping_count = 3; | ||
| // Number of unique offload users active in the hex during the epoch | ||
| uint64 offload_count = 4; |
There was a problem hiding this comment.
if i understand correctly, these 3 fields represent quantities of users in various categories. Consider a common naming convention or suffix between the fields to indicate this... ie: xxxx_user_count or xxx_subscriber_count
There was a problem hiding this comment.
addressed here: 1b9d954
|
@andymck looks great to me. |
dcyoung
approved these changes
Nov 17, 2024
dcyoung
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.