Feat/jupiter #452
Closed
Feat/jupiter #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bryzettler Do you plan to add swapping to pay for location assertion fees? |
|
@matthewcarlreetz not that I know of. This was just to add Jupiter as the main means for the SwapsScreen. What needs to be done for location assertion? |
bryzettler
requested review from
allenan,
tyler-whitman,
Perronef5,
ChewingGlass and
matthewcarlreetz
and removed request for
a team
|
Nothing necessarily. I was just thinking we could allow them to pay the re-assert fee with IOT, MOBILE, or HNT. Right now it will only burn HNT (if needed).
… On Sep 11, 2023, at 3:01 PM, Bryan ***@***.***> wrote:
@matthewcarlreetz <https://github.com/matthewcarlreetz> not that I know of. This was just to add Jupiter as the main means for the SwapsScreen. What needs to be done for location assertion?
—
Reply to this email directly, view it on GitHub <#452 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANN4NM7QIODNLLFDQCT6X3XZ5UY5ANCNFSM6AAAAAA4Q7MX6A>.
You are receiving this because you were mentioned.
|
ChewingGlass
requested changes
Sep 12, 2023
| } | ||
| }, [inputMint, outputMint, validOutputMints]) | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Do we want to useAsync here and catch/display errors?
There was a problem hiding this comment.
I think we're fine, this is just pulling the first validOutputMint and setting it as the default selected value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in all tokens from your visible tokens list and shows swaps based on that.