Disallow Unwanted Jump Labels #11893
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in key combinations from the possible jump labels.
Talia-12
changed the title
Talia-12
force-pushed
the
jump-label-follow-blacklist
branch
from
707eb2e
to
cd35f51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new option solving the same problem I was trying to solve in #11884 of the labels generated by the jump label system often being difficult to type. The solution implemented by this PR for the problem is a new option called jump-label-follow-blacklist. The option can be set to any map of letters to lists of letters that shouldn't follow it in the jump label.
For example, with a QWERTY keyboard labels like "az" and "aq" are more awkward to type since they require the same finger to hit both keys. With this PR, blocking those labels from showing up would be done by setting
jump-label-follow-blacklist: { a: "zq" }, making it so that a can't be followed by z or q.This is as configurable as a feature like this can possibly be, I think fairly ergonomic to use (easier to list keys that shouldn't go together than all the keys that should), and means no changes in configuration for people who don't want to use it, since previous configs will still parse and have the exact same functionality as they used to; it's a purely opt in feature.