feat: Allow mi and ma to use newlines
#12521
Open
+38
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helix-term/src/commands.rs
Outdated
|
|
||
| if let Some(ch) = event | ||
| .char() | ||
| .or((event.code == KeyCode::Enter).then_some('\n')) |
There was a problem hiding this comment.
Searching for \n is not exactly correct unless the document has LF line endings. This needs to search for doc.line_ending.as_str() instead. For a doc with CRLF line endings, selecting around \ns would exclude the opening \rs. The surround code needs to be refactored to accept &strs instead of chars in order to search for line endings
There was a problem hiding this comment.
I am going with a simpler implementation since we are dealing with line endings, I'm just using line_to_char to get information about the nth surrounding line ending. I hope that's fine
kirawi
added
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.