continue-comment: avoid continue comment for shebangs #12663
+40
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TornaxO7
commented
Jan 24, 2025
helix-term/src/commands.rs
Outdated
Comment on lines
3554
to
3569
| let continue_comment_tokens = { | ||
| static SHEBANG_REGEX: Lazy<Regex> = | ||
| Lazy::new(|| Regex::new(&["^", SHEBANG].concat()).unwrap()); | ||
|
|
||
| let curr_line_num = selection.primary().cursor_line(text); | ||
| let line = text.line(curr_line_num); | ||
|
|
||
| let is_not_shebang = curr_line_num > 0 | ||
| || line | ||
| .as_str() | ||
| .map(|line| SHEBANG_REGEX.captures(line).is_some()) | ||
| .unwrap_or(false); | ||
|
|
||
| if is_not_shebang | ||
| && comment_continuation == CommentContinuation::Enabled | ||
| && config.continue_comments |
There was a problem hiding this comment.
I'm a bit unsure about this part of the code. Is it fine if I move that into a private function within this module?
TornaxO7
force-pushed
the
avoid-shebang
branch
from
4babe8c to
d8d3202
Compare
|
I found a bug If you have this test: #!/b#(|i)#n/bash
echo "Hello, World!"
echo "Current date and t#[|i]#ime: n$(date)"hitting Enter will continue comment on the first line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12423
Is an integration test wanted here?