Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for path completion #2608

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Add support for path completion #2608

wants to merge 19 commits into from
+1,128 −216

Commits on Aug 24, 2024

  1. Adds support for path completion for unix paths 

    * Autocompletion is triggered with `/`.
* Documentation preview (file type, file permissions, canonicalized full path).
* Home-path resolution (`~/path`, `$HOME/path`, `${HOME}/path`)
* Link resolution (makes sense for preview, since the LSP specification (`CompletionItemKind`) only supports files and folders but not symlinks)
* Async (via `spawn_blocking` instead of tokios file accessor functions, as they IMHO make the code less readable and are quite a bit slower than just spawning a "thread")
* Configurable with `editor.path-completion` (default `true`), per-language overrideable path-completion support
    @Philipp-M
    Philipp-M committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    cc19db1 View commit details
    Browse the repository at this point in the history

  2. Handle windows CI

    @Philipp-M
    Philipp-M committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    aaf7c20 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Micro-optimization and revert of composing additional text edits

    @Philipp-M
    Philipp-M committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    ee5b319 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Use PartialEq for LspCompletionItem and don't prefix-filter path … 

    …completion items
    @Philipp-M
    Philipp-M committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    be1e616 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Michael Davis <[email protected]>
    @Philipp-M @the-mikedavis
    Philipp-M and the-mikedavis authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    f20cd4c View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @Philipp-M
    Philipp-M committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d02470f View commit details
    Browse the repository at this point in the history

  3. Fix cargo fmt

    @Philipp-M
    Philipp-M committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    de75bde View commit details
    Browse the repository at this point in the history

  4. Fix byte offsets in matched_path

    @Philipp-M
    Philipp-M committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    59b2cf5 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. implement robust path detection and env expansion

    @pascalkuthe @Philipp-M
    pascalkuthe authored and Philipp-M committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b08e6b6 View commit details
    Browse the repository at this point in the history

  2. use path::expand in path completions

    @pascalkuthe @Philipp-M
    pascalkuthe authored and Philipp-M committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a3e12ac View commit details
    Browse the repository at this point in the history

  3. use new path detection and expansions in goto_file

    @pascalkuthe @Philipp-M
    pascalkuthe authored and Philipp-M committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    1334606 View commit details
    Browse the repository at this point in the history

  4. Fix some typos.

    @Philipp-M
    Philipp-M committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    101bcc7 View commit details
    Browse the repository at this point in the history

  5. Apply review suggestions, and other smaller fixes.

    @Philipp-M
    Philipp-M committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8af7c67 View commit details
    Browse the repository at this point in the history

  6. Modularize path completion into separate functions

    @Philipp-M
    Philipp-M committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    57e34aa View commit details
    Browse the repository at this point in the history

  7. cargo fmt

    @Philipp-M
    Philipp-M committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d4a873d View commit details
    Browse the repository at this point in the history

  8. cargo clippy fix

    @Philipp-M
    Philipp-M committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ce885df View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Address review feedback

    @Philipp-M
    Philipp-M committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    3817321 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. improve completion cancelation

    @pascalkuthe @Philipp-M
    pascalkuthe authored and Philipp-M committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d73f158 View commit details
    Browse the repository at this point in the history

  2. Fix typos, and other cosmetic stuff

    @Philipp-M
    Philipp-M committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3dbcc4e View commit details
    Browse the repository at this point in the history