-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate IK URDF on-the-fly #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hello-binit
changed the title
WIP: Generate URDFs on-the-fly
WIP: Generate IK URDF on-the-fly
Oct 9, 2024
hello-binit
changed the title
WIP: Generate IK URDF on-the-fly
Generate IK URDF on-the-fly
Oct 9, 2024
hello-vinitha
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests pass on 3030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, Web Teleop's click-to-pregrasp feature required the user to run a script to generate a custom URDF for its inverse kinematics package. This step effectively cached a modified version of the calibrated URDF in
~/stretch_user
.Caching URDFs is a bad idea because a robot's "calibrated" URDF is unique to it, and likely won't work as well or at all on another Stretch robot. Even within a single robot, calibration parameters (e.g. backlash, offset, etc.) change over time, and it's common for users to use Stretch Calibration to recalibrate their robot. By caching the IK urdf, Web Teleop isn't keeping up with the latest calibration. This can also make debugging complicated because developers can't trust if their application is using the latest calibration.
A solution is to generate the URDF your application needs on-the-fly. Everytime Web Teleop is launched, it takes the URDF in
~/stretch_user
and creates the IK urdf it needs. Recently, the Stretch URDF package received a utility module to generate custom URDFs on-the-fly. This PR uses the new module to generate the IK URDFs it needs.Testing procedure
Create a new ROS workspace. You'll want to modify the
.repos
file in Stretch Install to pull this branch for Web Teleop (i.e. replaceversion: master
withversion: bugfix/dont_cache_urdf
on line 33). Then launch the interface as normal. Ensure click to pregrasp works as usual.Before opening a pull request
From the top-level of this repository, run:
pre-commit run --all-files
To merge
Squash & Merge