Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Improved scripts #116

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

WIP: Improved scripts #116

wants to merge 3 commits into from

Conversation

hello-binit
Copy link
Collaborator

Description

This PR improves the launch/stop scripts in this repo, including:

  • launch_interface.sh
  • start_ros2.sh
  • start_web_server_and_robot_browser.sh
  • stop_interface.sh

With launch_interface.sh it ensures the user always gets either SUCCESS or FAILURE messages, so it's clear whether web teleop succeeded in starting. Additionally, it logs to Stretch's log directory and creates a zip of the logs that can be shared with support if something goes wrong. Lastly, it shows the right URL to the user depending on whether they're running the local or online version of the interface.

With start_ros2.sh, it ensures all the ENV VARS are configured and calls CLIs using their absolute paths to ensure they're likely to execute correctly. It exits immediately if any command fails to execute. It also redirects verbose output to Stretch's log directory.

With start_web_server_and_robot_browser.sh, it takes in a -f flag and launches either the local or online version of the interface accordingly. It exits immediately if any command fails to execute. It also redirects verbose output to Stretch's log directory.

With stop_interface.sh, it fixes a bug where pkill is never called.

TODO:

  • Switch to using "local" vs "online" terminology because it is clearer. Remove mentions of Firebase and rename the "-f" flag.
  • Detect is wifi-connect is not installed and act accordingly

Testing procedure

[TODO: describe, in-detail, how you tested this. The procedure must be detailed enough for the reviewer(s) to recreate it.]

Before opening a pull request

From the top-level of this repository, run:

  • pre-commit run --all-files

To merge

  • Squash & Merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant