Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the launch/stop scripts in this repo, including:
launch_interface.sh
start_ros2.sh
start_web_server_and_robot_browser.sh
stop_interface.sh
With
launch_interface.sh
it ensures the user always gets either SUCCESS or FAILURE messages, so it's clear whether web teleop succeeded in starting. Additionally, it logs to Stretch's log directory and creates a zip of the logs that can be shared with support if something goes wrong. Lastly, it shows the right URL to the user depending on whether they're running the local or online version of the interface.With
start_ros2.sh
, it ensures all the ENV VARS are configured and calls CLIs using their absolute paths to ensure they're likely to execute correctly. It exits immediately if any command fails to execute. It also redirects verbose output to Stretch's log directory.With
start_web_server_and_robot_browser.sh
, it takes in a-f
flag and launches either the local or online version of the interface accordingly. It exits immediately if any command fails to execute. It also redirects verbose output to Stretch's log directory.With
stop_interface.sh
, it fixes a bug wherepkill
is never called.TODO:
wifi-connect
is not installed and act accordinglyTesting procedure
[TODO: describe, in-detail, how you tested this. The procedure must be detailed enough for the reviewer(s) to recreate it.]
Before opening a pull request
From the top-level of this repository, run:
pre-commit run --all-files
To merge
Squash & Merge